perl6-internals
[Top] [All Lists]

Re: [PATCH] Unified PMC/PObj accessors phase 2

To: malichus@mac.com (Gordon Henriksen)
Subject: Re: [PATCH] Unified PMC/PObj accessors phase 2
From: Leopold Toetsch <lt@toetsch.at>
Date: Fri, 6 Feb 2004 09:18:20 +0100
Cc: perl6-internals@perl.org
Delivered-to: mailing list perl6-all@perl.org
Delivered-to: perl6-all-poster@perl.org
Delivered-to: mailing list perl6-internals@perl.org
Delivered-to: perl6-internals@perl.org
In-reply-to: <0CC24344-585B-11D8-B545-000502994722@mac.com>
List-help: <mailto:perl6-all-help@perl.org>
List-post: <mailto:perl6-all@perl.org>
List-subscribe: <mailto:perl6-all-subscribe@perl.org>
List-unsubscribe: <mailto:perl6-all-unsubscribe@perl.org>
Mailing-list: contact perl6-all-help@perl.org; run by ezmlm
References: <0CC24344-585B-11D8-B545-000502994722@mac.com>
Reply-to: lt@toetsch.at
Gordon Henriksen <malichus@mac.com> wrote:

> The patch is at the URL below, and I've split it into 4 for you. The=20
> classes-include-lib patch must be applied before any of the other 3.=20
> I've resolved the 3-4 conflicts that occurred since the patch was first=20=

I've applied now "pmc-accessors2-classes-include-lib".
*But*

1) PObj_int_val or such doesn't exist, i.e. Buffer (logically) doesn't have
an int_val, so I renamed that back to PMC_int_val (for all PMC types).

2) The *misc.patch doesn't compile in jit/i386

3) *src-a*.patch reverts Mike's docu patch

4) didn't look at the second src patch then

Yeah such big patches are a pain.

Thanks anyway,
leo

> [* - Somewhat inadvisedly, I think. UnionVal is 8 bytes on a 32-bit=20
> architecture, but bloats to 16 bytes on a 64-bit architecture.

That's likely so because of alignment. But real numbers would be better
of course.

leo

Mailing-List: contact perl6-all-help@perl.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:perl6-all@perl.org>
List-Help: <mailto:perl6-all-help@perl.org>
List-Unsubscribe: <mailto:perl6-all-unsubscribe@perl.org>
List-Subscribe: <mailto:perl6-all-subscribe@perl.org>
Delivered-To: mailing list perl6-all@perl.org
Delivered-To: perl6-all-poster@perl.org
X-Mailing-List: contact perl6-internals-help@perl.org; run by ezmlm
X-Mailing-List-Name: perl6-internals
Delivered-To: mailing list perl6-internals@perl.org
Delivered-To: perl6-internals@perl.org
From: Leopold Toetsch <lt@toetsch.at>
Message-Id: <200402060733.i167XlZ05233@thu8.leo.home>
To: malichus@mac.com (Gordon Henriksen)
Subject: Re: Alignment Issues with *ManagedStruct?
In-Reply-To: <CCE95BBE-585D-11D8-B545-000502994722@mac.com>
References: <200402051023.i15ANdK10683@thu8.leo.home> 
<CCE95BBE-585D-11D8-B545-000502994722@mac.com>
Reply-To: lt@toetsch.at
Cc: perl6-internals@perl.org
Date: Fri, 6 Feb 2004 08:33:47 +0100
X-SMTPD: qpsmtpd/0.26, http://develooper.com/code/qpsmtpd/
X-SMTPD: qpsmtpd/0.26, http://develooper.com/code/qpsmtpd/
X-Spam-Filtered: 052f96e22adcb440ba93d277d4a1272f
X-Spam-Status: No, hits=-4.9 required=4.0 tests=BAYES_00
X-Spam-Flag: NO
X-Spam-Level: 

Gordon Henriksen <malichus@mac.com> wrote:

> Maybe you ought to capitulate to the hierarchical nature of it all and
> simply push on another struct layout specifier to handle the nesting.

Exactly that's the plan:

  .DATATYPE_STRUCT
  .DATATYPE_STRUCT_PTR

are already in CVS.

leo

<Prev in Thread] Current Thread [Next in Thread>